Restore ability to read Excel files to ExcelFiles and FileIO#63
Open
TimG1964 wants to merge 2 commits intoqueryverse:masterfrom
Open
Restore ability to read Excel files to ExcelFiles and FileIO#63TimG1964 wants to merge 2 commits intoqueryverse:masterfrom
TimG1964 wants to merge 2 commits intoqueryverse:masterfrom
Conversation
Author
|
It would be good to get some feedback on this PR. For example:
Just looking for a little guidance to temper my expectations! If it is accepted (and once XLSX.jl does make a release), I will quickly be able to make another PR to address #12. I think between both PRs most of the outstanding issues will be resolved. Two marked as enhancements (#34 and #38) might be handed off to XLSX.jl in any case - they are arguably out of scope of this package. I could also make a PR to streamline the tests if that would be helpful... Happy to take guidance. Thanks Tim |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExcelReaders.jl no longer supports .xlsx files, meaning that FileIO can no longer read data from Excel files. This PR removes this redundant dependence and instead uses XLSX.jl for reading - it is already used for writing.
There are a few points to note about this switch:
FileIO.loadhas changed. Instead of a singlerange, two arguments supply thesheetand thecolumns. Both are optional. There are further changes to the supported keyword arguments. These may technically be breaking changes but the functionality is already broken, so I think it doesn't matter here!missing, which FileIO returns asDataValue(). I've updated tests to reflect this.showtests.normalizenamesfor column names that are problematic. This changes the result of the test for reading data with a missing column name. I've includednormalizenamesin the Readme even though it won't be available until v0.11.0 is released.Where behaviour will change on release of v0.11.0, I've included tests for both versions (there are only three such tests) but have simply commented out the v0.11.0 tests. If/when a new version is released, it should be simple just to swap the commented lines.
Lastly, the third
showtest produces an output that is truncated. This seems to me to be a little brittle (don't know though!?) so I've commented it out.